Java Exception Handling

Problem description

Modules need dependencies of other modules only because of their exception classes

From validation/ItemValidating:

   String validateItemXml(final String itemXml) throws
           ValidationSchemaNotFoundException,
           TechnicalException;

From importmanager/ImportHandler:

   byte[] doFetch(String sourceName, String identifier) throws FileNotFoundException, 
           IdentifierNotRecognisedException, 
           SourceNotAvailableException, 
           TechnicalException,
           FormatNotRecognizedException;

Stacktraces are sometimes swallowed

   try 
   {
       ...					
   } 
   catch (MalformedURLException e) 
   {LOGGER.error("Error when replacing regex in fetching URL"); e.printStackTrace(); }
   catch(UnsupportedEncodingException e)
   {e.printStackTrace();}

   try 
   {
       ...					
   } 
   catch (JiBXException e) 
   {
       e.getCause();
   }

Sometimes, excessive stacktraces are shown, even without useful information

Example from coreservices: File:Exception1.txt

Logger.error, System.out and e.printStackTrace are mixed up happily

see above

No distinction between exceptions and errors/checked and unchecked exceptions

Compare Exception and Error

Links

OnJava: Best Practices for Exception Handling

Uniform Resource Locator